In a goods train, the brake delay is changed automatically from P to G

[manolollr]

For example, in the scenario wrzosy_tde330120 the locomotive and all the wagons are configured with P brake delay. According to this document from 2016:

https://www.zzmgliwice.pl/files/instrukcja_cw-1_2016_jednolity_zm2.pdf

at page 24, this is correct, because the train is shorter than 700 meters and its weight is lower than 800 tons.

But when you start the locomotive, specifically when you connect the compressor, the brake delay of all wagons is changed to G automatically.

After investigating the source code I've discovered that this is an intended behavior.

https://github.com/MaSzyna-EU07/maszyna

In the file Driver.cpp there is a function called AutoRewident that configures the brakes of the train according to the following facts:

- Longitude < 300m AND mass < 600Tons: Locomotive G, all the wagons P
- Longitude < 500m AND mass < 1300Tons: GP, Locomotive and next 5 vagons G, the other wagons P
- Other conditions: all wagons G

It seems these are following old rules. I suppose the rules from 2016 are newer, these are more permissive:

>= 700m Locomotive and all wagons to G
< 700m:
  - Mass < 800Tons: Locomotive and all wagons to P
  - Mass between 800 and 1200 tons: Locomotive G wagons P
  - Mass > 1200Tons: Locomotive and next 5 wagons to G (long locomotive), the other wagons to P

Which rules are correct? Must the code be modified to reflect 2016 rules? There are scenarios inspired in years earlier, like Linia053 is inspired in 2011. Maybe the code can be modified to allow different rules to be specified in the scenario file, and not hard-coded.

What can be done?

[Hirek]

Best would be implementing new entry in scn files like year or something so exe knows how to behave in certain conditions. (can be done via Global and scenariostateserializer ig).